From e39b8803643a31f62efc3512bc7d4603299752b3 Mon Sep 17 00:00:00 2001
From: Cain <75994858+cainthebest@users.noreply.github.com>
Date: Sat, 7 Sep 2024 00:33:53 +0100
Subject: [PATCH] refactor(buf): clean up out of bounds err msg

---
 crates/lib/src/buffer.rs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/crates/lib/src/buffer.rs b/crates/lib/src/buffer.rs
index 5485d90..549fabf 100644
--- a/crates/lib/src/buffer.rs
+++ b/crates/lib/src/buffer.rs
@@ -146,11 +146,10 @@ impl<'a, B: ByteOrder> Buffer<'a, B> {
     /// Returns a `BufferError` if there is an error decoding the string.
     pub fn read_string<D: StringDecoder>(&mut self, until: Option<D::Delimiter>) -> GDResult<String> {
         // Check if the cursor is out of bounds.
-        let remaining = self.remaining_length();
-        if self.cursor > remaining {
+        if self.cursor > self.remaining_length() {
             return Err(PacketUnderflow.context(format!(
-                "Cursor position {} is out of bounds when reading string. Remaining bytes: {remaining}",
-                self.cursor
+                "Cursor position {} is out of bounds when reading string. Buffer length: {}",
+                self.cursor, self.data.len()
             )));
         }