tribufu/node-gamedig
1
0
Fork 0
mirror of https://github.com/tribufu/node-gamedig synced 2026-06-01 09:42:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(core/http): remove got internal retry (#690)

Browse source 
* fix(core/http): remove got internal retry

* feat(protocol/brokeprotocolmaster): remove repeated default options in http request

* docs: add changelog line

* docs: credit contributor for the bug find
This commit is contained in:
CosminPerRam 2025-04-26 15:23:30 +03:00 • committed by GitHub
parent 6821e664b0
commit e24e9d0a9e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -1,6 +1,7 @@
## To Be Released... ## To Be Released...
## 5.X.Y ## 5.X.Y
* Fix: HTTP requests would end up making more retries than needed due to got's internal retry mechanism (#690, thanks @RattleSN4K3)
## 5.3.0 ## 5.3.0
* Docs: Arma Reforger query setup note (#670, thanks @xCausxn) * Docs: Arma Reforger query setup note (#670, thanks @xCausxn)

3
protocols/brokeprotocolmaster.js
View file

@ -128,8 +128,7 @@ export default class brokeprotocolmaster extends Core {
try { try {
await this.request({ await this.request({
url: this.backendApiUriCheck, url: this.backendApiUriCheck,
method: 'HEAD', method: 'HEAD'
retry: { limit: 0 } // TODO: #650 remove this
}) })
return true return true

3
protocols/core.js
View file

@ -316,6 +316,9 @@ export default class Core extends EventEmitter {
...params, ...params,
timeout: { timeout: {
request: this.options.socketTimeout request: this.options.socketTimeout
},
retry: {
limit: 0
} }
}) })
this.logger.debug(log => { this.logger.debug(log => {