fix(core/http): remove got internal retry (#690)

* fix(core/http): remove got internal retry

* feat(protocol/brokeprotocolmaster): remove repeated default options in http request

* docs: add changelog line

* docs: credit contributor for the bug find

CHANGELOG.md

@@ -1,6 +1,7 @@
 
 ## To Be Released...
 ## 5.X.Y
+* Fix: HTTP requests would end up making more retries than needed due to got's internal retry mechanism (#690, thanks @RattleSN4K3)
 
 ## 5.3.0
 * Docs: Arma Reforger query setup note (#670, thanks @xCausxn)

protocols/brokeprotocolmaster.js

@@ -128,8 +128,7 @@ export default class brokeprotocolmaster extends Core {
     try {
       await this.request({
         url: this.backendApiUriCheck,
-        method: 'HEAD',
-        retry: { limit: 0 } // TODO: #650 remove this
+        method: 'HEAD'
       })
 
       return true

protocols/core.js

@@ -316,6 +316,9 @@ export default class Core extends EventEmitter {
         ...params,
         timeout: {
           request: this.options.socketTimeout
+        },
+        retry: {
+          limit: 0
         }
       })
       this.logger.debug(log => {