Remove Players::setNum and stabilize field numplayers (#389)

* Remove Players Set Num

* Stabilize numplayers on armagetron

* Stabilize numplayers on ase

* Stabilize numplayers on assettocorsa

* Optimize away a variable declaration

* Stabilize numplayers on buildandshoot

* Stabilize numplayers on cs2d

* Fix wrong raw field parsed on Doom3

* Updated CHANGELOG and README regarding doom3 fix and numplayers

* Stabilize numplayers on doom3

* Stabilize numplayers on eco

* Stabilize numplayers on ffow

* Stabilize numplayers on quake2

* Stabilize numplayers on gamespy1

* Stabilize numplayers on gamespy2

* Stabilize numplayers on gamespy3

* Remove reductant numplayers setter in jc2mp

* Stabilize numplayers on kspdmp

* Stabilize numplayers on mafia2mp

* Stabilize numplayers on minecraftvanilla and remove players empty placeholders

* Stabilize numplayers on nadeo

* Stabilize numplayers on samp and reduce unused setters

* Stabilize numplayers on terraria

* Stabilize numplayers on tribes1

* Stabilize numplayers on unreal2

* Stabilize numplayers on valve

* Stabilize numplayers on ventrilo

* Battlefield: Set numplayers from info, not players

* Stabilize numplayers on minecraft

* Stabilize numplayers on teamspeak2

* Stabilize numplayers on teamspeak3

* Update CHANGELOG.md to add removal of players placeholders

* Replaced minecraft gamespy numplayers
This commit is contained in:
CosminPerRam 2023-10-27 19:48:56 +03:00 committed by GitHub
parent c51a75effb
commit da7a4a6334
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
37 changed files with 64 additions and 63 deletions

View file

@ -67,7 +67,7 @@ export default class valve extends Core {
state.raw.folder = reader.string()
state.raw.game = reader.string()
if (!this.goldsrcInfo) state.raw.appId = reader.uint(2)
state.raw.numplayers = reader.uint(1)
state.numplayers = reader.uint(1)
state.maxplayers = reader.uint(1)
if (this.goldsrcInfo) state.raw.protocol = reader.uint(1)
@ -301,7 +301,7 @@ export default class valve extends Core {
state.name = rules.bat_name_s
delete rules.bat_name_s
if ('bat_player_count_s' in rules) {
state.raw.numplayers = parseInt(rules.bat_player_count_s)
state.numplayers = parseInt(rules.bat_player_count_s)
delete rules.bat_player_count_s
}
if ('bat_max_players_i' in rules) {
@ -427,12 +427,11 @@ export default class valve extends Core {
})
delete state.raw.players
const numBots = state.raw.numbots || 0
const numPlayers = state.raw.numplayers - numBots
while (state.bots.length < numBots) {
if (sortedPlayers.length) state.bots.push(sortedPlayers.pop())
else state.bots.push({})
}
while (state.players.length < numPlayers || sortedPlayers.length) {
while (state.players.length < state.numplayers - numBots || sortedPlayers.length) {
if (sortedPlayers.length) state.players.push(sortedPlayers.pop())
else state.players.push({})
}