tribufu/node-gamedig
1
0
Fork 0
mirror of https://github.com/tribufu/node-gamedig synced 2026-06-01 09:42:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(core): throwing in tcpSend onData callback would crash (#705)

Browse source 
* fix(core): throwing in tcpSend onData callback would crash

* docs: update changelog for these changes
This commit is contained in:
CosminPerRam 2025-06-02 00:30:22 +03:00 • committed by GitHub
parent 49093f0b0f
commit da78c84c03
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -6,6 +6,7 @@
* Feat: 7 Days to Die get more optional Telnet data via an option (#693) * Feat: 7 Days to Die get more optional Telnet data via an option (#693)
* Feat: Update OpenTTD (By @mwkaicz #695) * Feat: Update OpenTTD (By @mwkaicz #695)
* Fix: Skip non-response packets in protocol-battlefield (By @cetteup #704) * Fix: Skip non-response packets in protocol-battlefield (By @cetteup #704)
* Fix: throwing in tcpSend onData callback would crash gamedig (#705, thanks @cetteup)
## 5.3.0 ## 5.3.0
* Docs: Arma Reforger query setup note (#670, thanks @xCausxn) * Docs: Arma Reforger query setup note (#670, thanks @xCausxn)

9
protocols/core.js
View file

@ -222,11 +222,16 @@ export default class Core extends EventEmitter {
async tcpSend (socket, buffer, ondata) { async tcpSend (socket, buffer, ondata) {
let timeout let timeout
try { try {
const promise = new Promise((resolve, _reject) => { const promise = new Promise((resolve, reject) => {
let received = Buffer.from([]) let received = Buffer.from([])
const onData = (data) => { const onData = (data) => {
received = Buffer.concat([received, data]) received = Buffer.concat([received, data])
const result = ondata(received) let result
try {
result = ondata(received)
} catch (e) {
reject(e)
}
if (result !== undefined) { if (result !== undefined) {
socket.removeListener('data', onData) socket.removeListener('data', onData)
resolve(result) resolve(result)