From 9bd3caab7b8b45d20349416419ddc36390325782 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Sat, 11 May 2024 18:47:38 +0300 Subject: [PATCH] feat(protocol/minecraft): reduce repeated code on promise.push --- protocols/minecraft.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/protocols/minecraft.js b/protocols/minecraft.js index 6888abd..86f8ddf 100644 --- a/protocols/minecraft.js +++ b/protocols/minecraft.js @@ -24,9 +24,7 @@ export default class minecraft extends Core { const vanillaResolver = new minecraftvanilla() vanillaResolver.options = this.options vanillaResolver.udpSocket = this.udpSocket - promises.push((async () => { - try { return await vanillaResolver.runOnceSafe() } catch (e) {} - })()) + promises.push(vanillaResolver) const gamespyResolver = new Gamespy3() gamespyResolver.options = { @@ -34,18 +32,15 @@ export default class minecraft extends Core { encoding: 'utf8' } gamespyResolver.udpSocket = this.udpSocket - promises.push((async () => { - try { return await gamespyResolver.runOnceSafe() } catch (e) {} - })()) + promises.push(gamespyResolver) const bedrockResolver = new minecraftbedrock() bedrockResolver.options = this.options bedrockResolver.udpSocket = this.udpSocket - promises.push((async () => { - try { return await bedrockResolver.runOnceSafe() } catch (e) {} - })()) + promises.push(bedrockResolver) - const [vanillaState, gamespyState, bedrockState] = await Promise.all(promises) + const ranPromises = promises.map(p => p.runOnceSafe().catch(_ => undefined)) + const [vanillaState, gamespyState, bedrockState] = await Promise.all(ranPromises) state.raw.vanilla = vanillaState state.raw.gamespy = gamespyState